Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APIGuildMember): add guild timeouts #235

Merged
merged 4 commits into from
Dec 21, 2021
Merged

feat(APIGuildMember): add guild timeouts #235

merged 4 commits into from
Dec 21, 2021

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Nov 9, 2021 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Reference Discord API Docs PRs or commits:

ImRodry
ImRodry suggested changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@ImRodry ImRodry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be string | null and not optional?

@suneettipirneni
Copy link
Member Author

Shouldn't these be string | null and not optional?

yeah

@ImRodry
Copy link
Contributor

ImRodry commented Nov 9, 2021

I believe the property is still not optional though, seems to be present on every member fetch

@suneettipirneni
Copy link
Member Author

I believe the property is still not optional though, seems to be present on every member fetch

gonna wait until the docs PR get's settled and I'll update the prop.

@Jiralite Jiralite mentioned this pull request Dec 15, 2021
Merged
5 tasks
@suneettipirneni
Copy link
Member Author

Upstream PR merged

@vladfrangu vladfrangu merged commit 0bbc972 into discordjs:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImRodry ImRodry ImRodry requested changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suneettipirneni @ImRodry @vladfrangu @SpaceEEC