Work on fixing bugs and medium-term improvements to codebase #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinaisslaying
added
bug
This was referenced Feb 26, 2024
carolinaisslaying
added
high priority
This comment has been minimized.
This comment has been minimized.
|
fix for css wasn't pretty but it works, working on the css splitting up and sorting out stuff can wait for a future release |
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to provide a medium-term solution in combination with @TheAlienKnight's fixes. Aiming to fix a number of bugs reported in the issues tab on this repo and fix things I come across.
His fixes very much fixed a lot of key integral things, but it's important to also build off of that and update more things where possible.
An example as of writing is switching to express-session and using Redis as a store instead of cookie-session and storing session information in cookies which, certainly isn't ideal and when updating passport to resolve its security vulnerabilities, rendered cookie-session unable to work with it due to newer breaking changes in passport.
The idea of this is not to be a silver bullet and fix everything that needs fixing, but fix a lot of the more high priority issues in functionality (or well, at least an attempt, lol), as well as address some of the more easier to fix bugs that have been reported, and high priority ones.