Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default_sort_order #5480

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

shaydewael
Copy link
Contributor

@shaydewael shaydewael commented Sep 20, 2022

Merged this in #5475, but it's not a stable field so reverting it for now.

@shaydewael shaydewael merged commit cf85bac into discord:main Sep 20, 2022
sebm253 pushed a commit to disgoorg/disgo that referenced this pull request Sep 20, 2022
@ooliver1
Copy link

ooliver1 commented Sep 20, 2022

This would be a breaking change (which is why this needs community discussion instead of merging instantly), why don't we have API V11 for these kinds of things already?

This is breaking because it was previously documented, and so was expected to not change until the next API bump (can’t expect this anymore sadly because of the amount of breaking changes we have had recently), but now may change at any time.

@MinnDevelopment
Copy link
Contributor

@ooliver1 it was merged by mistake yesterday and pretty much nobody is using it yet. Even if anyone used it, the field doesn't work properly in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants