update changelog for timeout feature #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
reviewed
Dec 20, 2021
|
this shouldn't be under the scheduled events header |
Lulalaby
reviewed
Dec 20, 2021
ah yea was fixing that in next commit, good catch :D |
update header Co-authored-by: Lala Sabathil <[email protected]>
update wording Co-authored-by: Lala Sabathil <[email protected]>
Lulalaby
reviewed
Dec 20, 2021
|
|
||
| ## Permissions For Timed Out Members | ||
|
|
||
| Timed out members will temporarily lose all permissions except `VIEW_CHANNEL` and `READ_MESSAGE_HISTORY`. Owners and admin users with `ADMINISTRATOR` permissions are exempt. |
There was a problem hiding this comment.
Suggested change
| Timed out members will temporarily lose all permissions except `VIEW_CHANNEL` and `READ_MESSAGE_HISTORY`. Owners and admin users with `ADMINISTRATOR` permissions are exempt. | |
| Timed out members will temporarily lose all permissions except `VIEW_CHANNEL` and `READ_MESSAGE_HISTORY`. Owners and users with `ADMINISTRATOR` permission are exempt. |
I think admin users is too much
There was a problem hiding this comment.
technically you're right but maybe in this case we can leave it just to make it extra clear, since devs are familiar with the term "admin user" we use elsewhere :)
7596ff
pushed a commit
to twilight-rs/twilight
that referenced
this pull request
Dec 27, 2021
Discord API PR (initial documentation): discord/discord-api-docs#4075 Discord API PR (further documentation): discord/discord-api-docs#4266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update change log and add timeout permissions clarifications