-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document guild time outs #4075
Merged
+85
−81
Merged
Document guild time outs #4075
Changes from 6 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
fc4ea37
Document `communication_disabled_until` on guild member object
bc423c8
Fix wording
5bea5ad
Fix punctuation
eba451f
Update docs/resources/Guild.md
dd7535e
Add modify payload for timeouts
Lulalaby 033c612
Add Guild Member Update field
Lulalaby 00fcb6f
Add disclaimer for 28 day limit
a425614
Fix wording, add permission
Lulalaby 29da1cd
Fix permissions..?
Lulalaby a56422f
Merge branch 'master' into guild-time-out
Lulalaby 53c7290
Update Permissions.md
Lulalaby 05c57d2
Fix description of permission 1L<<40
Lulalaby 497d2ce
Merge branch 'guild-time-out' of https://github.com/NurMarvin/discord…
Lulalaby 1585f10
Update Permissions.md
Lulalaby 2acfd85
chore: reference support article
be51418
Update docs/resources/Guild.md
Lulalaby 6c934c1
chore: add `MODERATE_MEMBERS` to list of internal names with differen…
95e71b0
fix: punctuation
65bbb10
Update docs/resources/Guild.md
Lulalaby d363509
Update docs/topics/Gateway.md
Lulalaby 8da728b
Update docs/resources/Guild.md
Lulalaby 6ba9994
add apostrophe
typpo ff789a4
more apostrophes!!
typpo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we reword the description to something more like:
"when the user's timeout will expire and the user's interaction in the guild is re-enabled.
null
if the user is not timed out."timeout / timed out / timing out
was avoided internally to keep the fields more generic and b/ctimeout
is an overloaded term, but it could be clearer to usetimeout / timed out
terminology at least in the descriptions here where we have more context, for the sake of having easily understandable docs. What do you think?(same note for descriptions in the rest of the PR too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done