Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden Active Threads #5369

Closed
imanataee opened this issue Aug 24, 2022 · 11 comments
Closed

Hidden Active Threads #5369

imanataee opened this issue Aug 24, 2022 · 11 comments

Comments

@imanataee
Copy link

imanataee commented Aug 24, 2022

Description

It seems the "hide after inactivity" option for threads is not working properly and is not closing the thread after the inactivity duration
What happens is that the threads will not be shown in the channel list of participants, but does not get archived (basically like a forum post)
This results into hidden active threads that can quickly result into servers hitting the 1000 threads cap

Steps to Reproduce

  1. Create a thread with any "HIDE AFTER INACTIVITY" amount
  2. Wait for that amount of time

Expected Behavior

Thread gets hidden and closed

Current Behavior

Thread gets hidden, but remains active

Client and System Information

Discord desktop client

@imanataee imanataee added the bug label Aug 24, 2022
@imanataee imanataee changed the title Threads Gets Hidden b Hidden Active Threads Aug 24, 2022
@imanataee
Copy link
Author

A helpful CM in the Discord Admin Community pointed this out:
#5365

It has been mentioned that:

Threads automatically archive after 7 days of inactivity (as a server approaches the max thread limit this timer will automatically lower, but never below the auto_archive_duration). "Activity" is defined as sending a message, unarchiving a thread, or changing the auto-archive time. The auto_archive_duration field previously controlled how long a thread could stay active, but is now repurposed to control how long the thread stays in the channel list. Channels can also set default_auto_archive_duration, which is used by our clients to pre-select a different auto_archive_duration value when a user creates a thread.

Probably it is supposed to be a convenience feature, but this part of it doesn't work correctly. Because at least my server hit the max thread limit having threads with 1 hour or 24 hours auto archive (by API requests) being there for 4 days or so

@ajpalkovic
Copy link
Contributor

It sounds like this is working as intended. The docs were updated yesterday to reflect this change.
We'll keep an eye on how many servers are hitting the thread limit as always, but right now it's seven, across all of Discord which is a good sign that things are still working.

@ajpalkovic
Copy link
Contributor

Apologies, you were right about it not working :D One of the parts of the new system actually didn't get deployed, so I've kicked that off and I'll make sure that happens today!

@imanataee
Copy link
Author

Amazing! Thank you for the attention and care @ajpalkovic <3

@ajpalkovic
Copy link
Contributor

Are things working better now?

@imanataee
Copy link
Author

I made a bot solution for the auto-archive before the bug report, so my threads went down from 1000 to 100, which makes me unable to confirm if things are better now
But I can try to turn the bot off to make sure or make 900 threads (?)

@MarcusOtter
Copy link

MarcusOtter commented Aug 28, 2022

I encountered this bug today. I set the auto_archive_duration to 1 hour. After 1 hour, the thread is hidden in the client, but it is not archived. I can still react and press buttons in it. And for what it's worth, discord.js does not emit a threadUpdate event after this hour is up, which indicates to me that the API is still broken around this. @ajpalkovic

@advaith1
Copy link
Contributor

@MarcusOtter as people mentioned earlier in this thread, that is an intentional change documented in #5365; auto_archive_duration now controls hiding, not archiving

@MarcusOtter
Copy link

MarcusOtter commented Aug 28, 2022

Ah, I skimmed the docs PR and missed the last part. Thanks.

Threads automatically archive after 7 days of inactivity (as a server approaches the max thread limit this timer will automatically lower, but never below the auto_archive_duration)

EDIT:
Too bad the "hiding" part doesn't exist in the API. I want my bot to react to thread start messages when they were auto-archived without a reply by someone, which would help people find threads that they didn't respond to in time.

@ayyneya
Copy link

ayyneya commented Aug 28, 2022

@ajpalkovic

Hi, is there any way around this change?
Threads in my server get used more than normal channels, archive after 1h or 24h kept our sanity.

Now with them archiving after 7 days, I have approx 40 threads open now. It's really cluttered.

@ajpalkovic
Copy link
Contributor

ajpalkovic commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants