PR feedback and comments #88
Conversation
There was a problem hiding this comment.
I forgot this file the first time but this tests all the required flags and required args for the initCmd
| @@ -59,7 +63,7 @@ func initRunE(cmd *cobra.Command, args []string) error { | |||
|
|
|||
| switch stores.StoreType(backend) { | |||
| case stores.StoreTypeS3: | |||
| cfg = config.InitializeStoreTypeS3Config( | |||
| cfg = config.InitializeStoreTypeS3( | |||
There was a problem hiding this comment.
comment to simplify the InitStoreTypeS3 fn name
| @@ -10,14 +10,14 @@ import ( | |||
| "github.com/spf13/viper" | |||
| ) | |||
|
|
|||
| func initCommand() *cobra.Command { | |||
| func initCmd() *cobra.Command { | |||
There was a problem hiding this comment.
standardized the fn Cmd() names as recommended
| @@ -8,15 +8,15 @@ import ( | |||
| "github.com/stretchr/testify/require" | |||
| ) | |||
|
|
|||
| func TestRootCommand(t *testing.T) { | |||
| func TestRootCmd(t *testing.T) { | |||
There was a problem hiding this comment.
aligned with golang standards on unit testing fn names
| } | ||
|
|
||
| return uploadCmd | ||
| } | ||
|
|
||
| func uploadRunE(cmd *cobra.Command, objects []string) error { | ||
| // uploadFn is the execution runtime for the uploadCmd functionality |
There was a problem hiding this comment.
this is the start for godoc generation to document functions inline with comments
| initCommand(), | ||
| retrieveCommand(), | ||
| uploadCommand(), | ||
| initCmd(), |
There was a problem hiding this comment.
align with fn Cmd() names
| subArgs, | ||
| ) | ||
|
|
||
| // Check the required flags exist: |
There was a problem hiding this comment.
test that all of the required flags appear...this is important as it ensures we don't miss this in the implementation and aligns our docs with cmd functionality
| @@ -27,6 +27,7 @@ go_test( | |||
| name = "cli_test", | |||
| srcs = [ | |||
| "helpers_test.go", | |||
| "init_test.go", | |||
TO: @discentem @natewalck
CHANGES
CONTEXT
Because I am still learning Sapling...I didn't perform the stacked-PR correctly so this PR contains all of the PR feedback from the last one.