Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start splitting BondsTable notebook into separate files #17

Merged
merged 3 commits into from
Jul 8, 2023

Conversation

disberd
Copy link
Owner

@disberd disberd commented Jul 8, 2023

This PR starts splitting the big notebook defining the StructBond into multiple julia files.

Initially the idea was to split this into smaller notebooks that are joined together using the new @fromparent macro from PlutoDevMacros.

Eventually this will be done as part of normal julia files, and @fromparent is probably just gonna be used to test the functionality within a notebook.

It's cool to have all the functionality in a single notebook but it can be quite heavy to load for doing changes, and it can also be quite daunting to look at the huge source file of the notebook, especially with the huge additions (in terms of line numbers) due to cell delimiters, cell order and most importantly Manifest file inclusion

Splitting is done.
Added also a notebook internal to the structbond folder for testing the specific functionality and live changes exploiting the @fromparent macro

@disberd disberd merged commit fe93a00 into master Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant