Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace template variable #181

Closed
wants to merge 2 commits into from
Closed

Conversation

asemarian
Copy link
Contributor

Description of the change

  • Added namespaceOverride template variable to support flexible namespace configurations.
  • Introduced helper function in helpers.tpl for namespace resolution.
  • Updated relevant templates to utilize the new namespace logic.
  • Bumped Helm chart version to 2.21.0.

Benefits

When using cdk8s, you can't scope your resources to a namespace unless the Helm chart has a template variable for that.

Possible drawbacks

None that come to mind.

Applicable issues

N/A

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md

@asemarian asemarian requested a review from dirsigler as a code owner October 22, 2024 13:38
@fgeck
Copy link
Contributor

fgeck commented Dec 31, 2024

Hey @dirsigler,
would it be possible to merge this PR?
I would love to use namespaceOverride

@dirsigler
Copy link
Owner

Hey @asemarian abd @fgeck ,
I think I can merge this once the Chart.yaml version bump was updated and reflects the change in README.md via helm-docs.

Thank you for your work and patience!

Copy link
Owner

@dirsigler dirsigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflict.

@fgeck fgeck mentioned this pull request Jan 4, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants