Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to mount additional existing volumes #128

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

nobbs
Copy link
Contributor

@nobbs nobbs commented Sep 5, 2023

Description of the change

Adds the option to specify additional volumes and volume mounts that will be passed to the Deployment or StatefulSet. This feature might be used to provide Uptime Kuma with additional certificate authorities based on louislam/uptime-kuma#1380 given the CA files in a configmap.

Benefits

Ability to mount additional files / folders / volumes into the Uptime Kuma pod.

Possible drawbacks

--

Applicable issues

--

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md

this might be useful if you want to mount additional CAs from a configmap.
@nobbs nobbs requested a review from dirsigler as a code owner September 5, 2023 14:15
@dirsigler
Copy link
Owner

Hey @nobbs ,
seems like a cool feature addition. By any chance you were able or could be able to test this feature out somehow?

This kind of feature (volumes) unfortunately is not covered by the GitHub Actions workflow with the KinD cluster.

@dirsigler dirsigler self-assigned this Sep 5, 2023
@dirsigler dirsigler added the enhancement New feature or request label Sep 5, 2023
@nobbs
Copy link
Contributor Author

nobbs commented Sep 5, 2023

I did manually by setting the values and running helm template. I can look into testing it automatically as part of the CI tomorrow.

@dirsigler
Copy link
Owner

Hey,
Additional CI/CD Tests are not needed from my side, but if got something quick up I am obviously happy about it.

Was more thinking if you have some local cluster up where you can test the functionality 😅.

Sitting at a conference currently so could earliest check it out today evening on my own.

@dirsigler dirsigler merged commit 6c26844 into dirsigler:main Sep 8, 2023
@nobbs nobbs deleted the feat/additional-volumes branch September 8, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants