Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a bit of a unique situation, because I created a development environment for trying to dev on this project, and so my DC's IP addresses aren't all accessible from my bloodhound-python host. I can only reach the top IP address from the picture below ( IPs are getting printed out from this section to debug ).
So, I needed to force it to use the top IP address. Since that was not an option from the current CLI flag I added them, and figured if you all wanted to merge them you can. Let me know if you need me to modify anything to meet/conform to your project's processes/code patterns. Below are some pictures from after I made the changes to show it works.
After modification normal but not specifying the
-dc-ip
flag.Specifying the
-dc-ip
flag.Warning when user specifies an IP address that isn't in the returned addresses ( error was from a
Ctrl+c
to stop it, and theFalse
output was removed ( was using for debugging ) ).