Added LDAP Channel Binding Support #148
Open
+69
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the default protocol in domain.py to match that of authentication.py Removed a line in authentication.py that recreates the conn variable before binding which seemed unnecessary
|
i merged this manually and it solved my problem. can we get this into the main line? |
|
Yes worked for me as well, but needed a small fix for Kerberos authentication deadjakk#1 |
Fix kerberos authentication & no-pass Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once added, I was able to fully enumerate a domain with ldap channel signing enforced as intended.
Maybe double check the removal of line 107 of bloodhound/ad/authentication.py where I got rid of the "additional"
connvariable creation. It seemed redundant, but you be the judge. If it needs to stay then the ldap channel binding arg needs to be passed there as well.