Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BBCCoUkIPlayerPlaylistIE #1

Closed
wants to merge 1 commit into from

Conversation

dirkf
Copy link
Owner

@dirkf dirkf commented Mar 5, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

The BBCCoUkIPlayerPlaylistIE extractor was failing, whereas BBCCoUkPlaylistIE still worked for the same pids: eg, the _TESTS.

In the IPlayer series pages, the playlist metadata is now sent in a JSON expression within a <script> element, and this patch extracts the title and description from it, and modifies the _VIDEO_ID_TEMPLATE to match the episode links within the entities subobject of the JSON.

The playlist metadata is now sent in a JSON expression within a <script> element.
@dirkf dirkf closed this Mar 5, 2021
@dirkf dirkf deleted the dirkf-BBCCoUkIPlayerPlaylistIE-patch1 branch March 5, 2021 23:10
dirkf added a commit that referenced this pull request May 21, 2023
* remove discoverynetworks.py
dirkf added a commit that referenced this pull request Jul 12, 2023
Adated from yt-dlp/yt-dlp-GHSA-v8mc-9377-rwjj/pull/1/commits/101caac
Thx coletdjnz
dirkf added a commit that referenced this pull request Jul 18, 2023
Adated from yt-dlp/yt-dlp-GHSA-v8mc-9377-rwjj/pull/1/commits/101caac
Thx coletdjnz
dirkf added a commit that referenced this pull request Jul 18, 2023
Adated from yt-dlp/yt-dlp-GHSA-v8mc-9377-rwjj/pull/1/commits/101caac
Thx coletdjnz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant