Handle Starknet events keys/data correctly #1142
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kus
force-pushed
the
fix/starknet-events-keys-matcher
branch
from
c38ca0e to
be4ac14
Compare
m-kus
force-pushed
the
fix/starknet-events-keys-matcher
branch
2 times, most recently
from
8d2c8f0 to
360ca3e
Compare
m-kus
force-pushed
the
fix/starknet-events-keys-matcher
branch
from
360ca3e to
7453f73
Compare
m-kus
requested review from
droserasprout and
Wizard1209
and removed request for
droserasprout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any field in Starknet event can be marked as
key(which is the same as topic in EVM) thus we need to make sure the deserializers are ordered correctly before we apply them to the raw event data (keys + data).Note that we cannot reorder data instead because particular types might be encoded with more than one felt.
Requires software-mansion/starknet.py#1520