Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tests with OCaml 5.2 #37

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

kit-ty-kate
Copy link
Contributor

Same as mirage/mrmime#99, mirage/pecu#14 and dinosaure/unstrctrd#17

#=== ERROR while compiling multipart_form.0.5.0 ===============================#
# context              2.2.0~beta2~dev | linux/x86_64 | ocaml-variants.5.2.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.2/.opam-switch/build/multipart_form.0.5.0
# command              ~/.opam/5.2/bin/dune runtest -p multipart_form -j 1
# exit-code            1
# env-file             ~/.opam/log/multipart_form-1594-240fcf.env
# output-file          ~/.opam/log/multipart_form-1594-240fcf.out
### output ###
# File "test/dune", line 13, characters 0-117:
# 13 | (rule
# 14 |  (alias runtest)
# 15 |  (package multipart_form)
# 16 |  (deps
# 17 |   (:test test.exe))
# 18 |  (action
# 19 |   (run %{test} --color=always)))
# (cd _build/default/test && ./test.exe --color=always)
# Testing `multipart_form'.
# This run has ID `F4MR7GX6'.
# 
#   [OK]          content-type                      0   text/plain; charset=us-...
#   [OK]          content-type                      1   text/plain; charset="us...
#   [OK]          content-type                      2   text/plain; charset=ISO...
# > [FAIL]        multipart_form (decoder)          0   simple.
#   [FAIL]        multipart_form (decoder)          1   simple with helpers.
#   [OK]          multipart_form (encoder)          0   simple.
#   [FAIL]        filename with space               0   filename with space.
# 
# ┌──────────────────────────────────────────────────────────────────────────────┐
# │ [FAIL]        multipart_form (decoder)          0   simple.                  │
# └──────────────────────────────────────────────────────────────────────────────┘
# ASSERT unamed values
# File "test/test.ml", line 105, character 6:
# FAIL unamed values
# 
#    Expected: `1'
#    Received: `0'
# 
# Raised at Alcotest_engine__Test.check in file "src/alcotest-engine/test.ml", lines 200-210, characters 4-19
# Called from Dune__exe__Test.simple_multipart_form.(fun) in file "test/test.ml", line 105, characters 6-60
# Called from Alcotest_engine__Core.Make.protect_test.(fun) in file "src/alcotest-engine/core.ml", line 181, characters 17-23
# Called from Alcotest_engine__Monad.Identity.catch in file "src/alcotest-engine/monad.ml", line 24, characters 31-35
# 
# Logs saved to `~/.opam/5.2/.opam-switch/build/multipart_form.0.5.0/_build/default/test/_build/_tests/multipart_form/multipart_form U+0028decoderU+0029.000.output'.
#  ──────────────────────────────────────────────────────────────────────────────
# 
# Full test results in `~/.opam/5.2/.opam-switch/build/multipart_form.0.5.0/_build/default/test/_build/_tests/multipart_form'.
# 3 failures! in 0.001s. 7 tests run.

@dinosaure
Copy link
Owner

Thanks!

@dinosaure dinosaure merged commit 49635b2 into dinosaure:main Apr 4, 2024
1 check was pending
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Apr 13, 2024
CHANGES:

- Introduce a new package `multipart_form-eio` (@Willenbrink, dinosaure/multipart_form#35)
- Delete the `result` dependency (@dinosaure, dinosaure/multipart_form#38)
- Fix tests for OCaml 5.2 (@kit-ty-kate, dinosaure/multipart_form#37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants