Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obfuscate password length in account dialog (fixes #797) #1474

Closed
wants to merge 2 commits into from

Conversation

eerielili
Copy link
Contributor

@eerielili eerielili commented Aug 15, 2023

Closes issue #797.
By default, it displays a password length of 12 characters regardless of the real password length.

@fiaxh
Copy link
Member

fiaxh commented Jun 20, 2024

This should be solved as part of 21ae427, as the field no longer exists in that form.

Previously, it wasn't clear what the password entry field actually does. Now, passwords are only displayed (in dots) when the user enters them. Previously, editing the password field only made sense after the password was changed on another device. This case is now explicitly handeled like this:

@fiaxh fiaxh closed this Jun 20, 2024
@eerielili
Copy link
Contributor Author

@fiaxh Neat!

@eerielili eerielili deleted the obsfucate-password-length branch June 20, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants