Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use common unified tokens #68

Merged

Conversation

LuPoYi
Copy link
Contributor

@LuPoYi LuPoYi commented Jun 23, 2024

  • send, multisend, permit2 token list get from common.getUnifiedTokens
  • remove common tokens from src/logics/xxxxx/tokens/data/xxxxxx.json, use common.mainnetTokens instead
  • yarn changeset
  • update protocolink/x dependencies

@LuPoYi LuPoYi force-pushed the feature/use_common_unified_tokens_20240623 branch from bb30f34 to 3f49afa Compare June 24, 2024 08:46
@LuPoYi LuPoYi force-pushed the feature/use_common_unified_tokens_20240623 branch from 3f49afa to cd76089 Compare June 25, 2024 02:51
@zodahu
Copy link
Contributor

zodahu commented Jun 25, 2024

protocolink-logics/src/logics/syncswap/tokens/index.ts should also use common.zksyncTokens

src/logics/radiant-v2/tokens/data/arbitrum.json Outdated Show resolved Hide resolved
src/logics/stargate/tokens/index.ts Outdated Show resolved Hide resolved
src/logics/uniswap-v3/tokens/data/base.json Outdated Show resolved Hide resolved
@zodahu
Copy link
Contributor

zodahu commented Jun 25, 2024

For paraswap-v5 & zeroex-v4 we can do the following changes

  1. Partially rollback src/logics/paraswap-v5/configs.ts in this PR https://github.com/dinngo/protocolink-logics/pull/44/files, i.e. move the content of getDefaultTokenListUrls and getTokenList and tests in src/utils/tokens.ts back to paraswap-v5, note that there is no default naming.
  2. Apply zeroex-v4 with getUnifiedTokens same as logic.send-token.ts

@LuPoYi LuPoYi marked this pull request as ready for review June 25, 2024 05:51
src/utils/tokens.test.ts Show resolved Hide resolved
src/logics/uniswap-v3/tokens/data/base.json Outdated Show resolved Hide resolved
@LuPoYi LuPoYi force-pushed the feature/use_common_unified_tokens_20240623 branch from cfa2ba8 to f2cc556 Compare June 25, 2024 08:46
@zodahu
Copy link
Contributor

zodahu commented Jun 25, 2024

LGTM

@LuPoYi LuPoYi merged commit 3601261 into dinngo:master Jun 25, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants