Migrate resource ec_deployment_traffic_filter to terraform-provider-framework #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascal-hofmann
force-pushed
the
feature/530/trafficfilterresource
branch
3 times, most recently
from
4803616 to
5a193b0
Compare
10 tasks
dimuon
reviewed
Sep 20, 2022
dimuon
reviewed
Sep 20, 2022
| if err := d.Set("include_by_default", res.IncludeByDefault); err != nil { | ||
| return err | ||
| } | ||
| diags.Append(flattenRules(ctx, res.Rules, &state.Rule)...) | ||
|
|
||
| if res.Description != "" { |
There was a problem hiding this comment.
It looks like Description.Null if false here. Shall we remove the if check or set Null to true if Description is empty?
There was a problem hiding this comment.
Good catch. Fixed.
|
@pascal-hofmann , I'm sorry if I missed something, but does it make sense to add migration tests as you did in the previous PR? |
pascal-hofmann
force-pushed
the
feature/530/trafficfilterresource
branch
2 times, most recently
from
64e7b70 to
eef1ebe
Compare
I just added the missing migration test. |
pascal-hofmann
force-pushed
the
feature/530/trafficfilterresource
branch
from
eef1ebe to
4307d41
Compare
…ramework The behavior of the default_value plan_modifier changes, so it also applies default values when the value has been explicitly specified before. Unit test timeout increased. Switch to v6 provider in tests.
pascal-hofmann
force-pushed
the
feature/530/trafficfilterresource
branch
from
4307d41 to
c197f28
Compare
dimuon
approved these changes
Sep 21, 2022
dimuon
added a commit
that referenced
this pull request
Feb 2, 2023
Migrate resource ec_deployment_traffic_filter to terraform-provider-framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate resource ec_deployment_traffic_filter to terraform-provider-framework
The behavior of the default_value plan_modifier changes, so it also applies default values when the value has been explicitly specified before.
Unit test timeout increased.
Related Issues
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist