Migrate ec_deployment

[dimuon]

Description

ec_deployment resource migration

Limitations.
State upgrade is not currently implemented.

Few acceptance tests fail. Please see the section below.

Related Issues

Motivation and Context

How Has This Been Tested?

• unit tests (majority of the relevant unit tests were migrated)
• acceptance tests
• manual testing

There are still few acceptance tests that fail:

• there are 4 acceptance tests (their names mention version 0.4.1) that verify migration of other data sources and resources from 0.4.1 to 0.6.0. To fix them we need implement a state upgrade for ec_deployment.
• TestAccDeploymentExtension_pluginDownload fails on 0.4.1 with the same error ("Custom plugin is not allowed at your subscription level.")
• TestAccDeploymentExtension_bundleFile fails quite often on both 0.4.1 and the branch with the "failed to upload file" error.
• TestAccDeployment_withExtension fails quite often with the same error as TestAccDeploymentExtension_bundleFile.

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (improves code quality but has no user-facing effect)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation

Readiness Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed

[dimuon]

@pascal-hofmann , the schema for ec_deploment resource is more or less complete. More probably we will need to tune/fix it once CRUD operations are ready. As for now I tested it just on a small set of examples.

[pascal-hofmann]

@dimuon Do you need help with ec_deployment or should I start with porting one of the other resources?

[dimuon]

@pascal-hofmann , I think it makes sense to either start porting other resources or maybe adding acceptance tests for the migration, as recommended by Terraform - https://github.com/hashicorp/terraform-plugin-framework/blob/main/website/docs/plugin/framework/migrating/testing.mdx.

[dimuon]

@pascal-hofmann , I've pushed still unfinished implementation of Read for ec_deployment. I tested it on a resource that was created with the previous version. The problem is that the plan is not empty for a configuration that doesn't introduce any change (basically I've created a resource using the old provider and then executed terraform plan using the new implementation and the existing resource configuration that was untouched). I'm looking into this.

Also, it looks like changes you've suggested aren't compilable - Value property isn't available in the snippets you've commented on.

[pascal-hofmann]

Also, it looks like changes you've suggested aren't compilable - Value property isn't available in the snippets you've commented on.

My IDE (goland) deceived me with this. I had problems with Value.String() and assumed this is the same here, because goland found these usages. I should have tested my suggestions locally. Sorry for the confusion.

[pascal-hofmann]

The recommended way to deal with configuration or plan data for now is using types package types in Go structs, e.g.

type myModel struct {
  ExampleList types.List `tfsdk:"example_list"`
}

-- https://discuss.hashicorp.com/t/terraform-plugin-framework-value-conversion-error-unhandled-unknown-value/44382/3

[dimuon]

Yeah, it's a valid concern. It looks like there is also an option to leverage appropriate interfaces.
I'll reconsider these definitions when I complete Create/Update.
Thank you for the heads-up.

[pascal-hofmann]

LGTM apart from minor things. I did not do any real world tests with the new ec_deployment resource though.