Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and remove external provider workaround from migration tests #11

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Update dependencies and remove external provider workaround from migration tests #11

merged 1 commit into from
Sep 23, 2022

Conversation

pascal-hofmann
Copy link
Collaborator

@pascal-hofmann pascal-hofmann commented Sep 23, 2022 •
edited
Loading

Update dependencies and remove external provider workaround from migration tests.

This also updates to terraform-plugin-framework 0.13.0 which drops datasource.DataSourceWithGetSchema, datasource.DataSourceWithMetadata, resource.ResourceWithGetSchema, resource.ResourceWithMetadata.

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Base automatically changed from feature/530/elasticsearchkeystoreresource to feature/530/migrate-to-plugin-framework September 23, 2022 08:53
@pascal-hofmann pascal-hofmann marked this pull request as ready for review September 23, 2022 08:59
dimuon
dimuon approved these changes Sep 23, 2022
View reviewed changes
Copy link
Owner

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimuon dimuon merged commit 07aecc1 into feature/530/migrate-to-plugin-framework Sep 23, 2022
dimuon added a commit that referenced this pull request Feb 2, 2023
@dimuon
Merge pull request #11 from dimuon/update-dependencies
06422af 
Update dependencies and remove external provider workaround from migration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimuon dimuon dimuon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascal-hofmann @dimuon