Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate resource ec_deployment_elasticsearch_keystore to terraform-plugin-framework #10

Conversation

pascal-hofmann
Copy link
Collaborator

Migrate resource ec_deployment_elasticsearch_keystore to terraform-plugin-framework

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@pascal-hofmann pascal-hofmann force-pushed the feature/530/elasticsearchkeystoreresource branch from 4988a27 to 7e28390 Compare September 22, 2022 09:00
@pascal-hofmann pascal-hofmann marked this pull request as ready for review September 22, 2022 09:06
Copy link
Owner

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascal-hofmann pascal-hofmann merged commit 993d47d into feature/530/migrate-to-plugin-framework Sep 23, 2022
@pascal-hofmann pascal-hofmann deleted the feature/530/elasticsearchkeystoreresource branch September 23, 2022 08:53
dimuon pushed a commit that referenced this pull request Sep 27, 2022
dimuon pushed a commit that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants