Code Style #135
Code Style #135
Conversation
code style upd editor config usings fix _ fix editorconfig
There was a problem hiding this comment.
Looks good.
I was so very confused about the await using in
await using var fileStream = System.IO.File.OpenRead(filePath);on account of OpenRead not being async. It just returns a FileStream, which itself is an object not async thing itself. Even removing the await my IDE was like "hey you should add await here".
I had not used this syntax before (but I have used something like similar which is using (var file = myObject.OpenFileAsync('...'));) and wanted to understand it to make sure it is correct here.
What I found is await using is meaning that the object returned must implement IAsyncDisposable, something I also hadn't seen before. It turns out the FileStream class is a subclass of Stream class, which itself is IAsuncDisposable.
I use File.OpenRead in other projects but it hasn't tried to prompt me for the change there. This has given me something to go look into to see why.
Description
I did a little work on the code style
PR Checklist
main