Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upd sample #130

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Upd sample #130

merged 2 commits into from
Oct 31, 2024

Conversation

dimonovdd
Copy link
Owner

PR Checklist

  • All projects build
  • Has samples
  • Rebased onto current main

@dimonovdd dimonovdd requested a review from beeradmoore October 29, 2024 15:13
@beeradmoore
Copy link
Collaborator

In this PR can we change the MAUI version in MediaGallery down to 8.0.3?

Reason being that it is currently 8.0.92, but if my app is using 8.0.82 I won't be able to use the nuget generated as its minimum is higher than my current. At least if it's 8.0.3 it should lock to .NET 8 MAUI apps, and it will internally use whatever their main app is currently using. Keeping it at 8.0.92 in the sample project is the right call.

@beeradmoore beeradmoore mentioned this pull request Oct 29, 2024
Merged
3 tasks
@dimonovdd
Copy link
Owner Author

I haven't researched how all these versions work in MAUI yet. In this PR, I tried only to correct the code style and gross errors in Sample project.

@beeradmoore
Copy link
Collaborator

No worries, I'll get though this in the next 12h.

beeradmoore
beeradmoore approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@beeradmoore beeradmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There was a few Android changes so ran it on my Android device as well as reviewing code, worked great.

@dimonovdd dimonovdd merged commit 7f71ea3 into main Oct 31, 2024
@dimonovdd dimonovdd deleted the upd-sample branch October 31, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeradmoore beeradmoore beeradmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimonovdd @beeradmoore