add f64 support #61
Draft
add f64 support #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ughuuu
commented
Oct 14, 2024
Ughuuu
commented
- Fixes Add 64bit support #47
Vrixyz
reviewed
Oct 14, 2024
Vrixyz
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Thanks for the suggestion and pull request! I think that's reasonable :)
Adding new crates to maintain is not a light consideration though, so I can't promise anything and will defer to @sebcrozet for further progress.
src/lib.rs
Outdated
Comment on lines
44
to
46
| #[cfg(all(feature = "dim2", feature = "rapier"))] | ||
| #[cfg(all(feature = "dim3", feature = "f64"))] |
There was a problem hiding this comment.
"rapier" feature will still be needed if we want to keep salva optionally independent from parry.
|
No worries, adding them here too just to be safe, I will probl have them in my fork or branch custom-branch and use them there. If they are ever accepted, thats ok too :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.