Fix wavefront tests + new test for different pos + add them in ci #268
Conversation
Vrixyz
commented
Sep 12, 2024
Vrixyz
commented
- Follow up to Fix minor bug in mesh mesh intersection #258
| &cuboid_mesh, | ||
| false, | ||
| &Isometry::translation(2.0, 0.0, 0.0), | ||
| &sphere_mesh, //.clone().scaled(&Vector3::new(1.001, 1.001, 1.001)), |
There was a problem hiding this comment.
That comment will have to be removed, but I added that because setting both positions to 200;0;0 resulted in a lot of holes in the resulting intersection. I can imagine this is floating point imprecision but it was surprising.
There was a problem hiding this comment.
Interesting. I think it’s worth opening an issue with the example that generates holes.
There was a problem hiding this comment.
I opened #270 ; it can even be reproduced in a position of 2;0;0
| &cuboid_mesh, | ||
| false, | ||
| &Isometry::translation(2.0, 0.0, 0.0), | ||
| &sphere_mesh, //.clone().scaled(&Vector3::new(1.001, 1.001, 1.001)), |
There was a problem hiding this comment.
Interesting. I think it’s worth opening an issue with the example that generates holes.
| # Adds `TriMesh:to_obj_file` function. | ||
| wavefront = ["obj"] |
There was a problem hiding this comment.
Adding documentation on cargo.toml is idiomatic to rust ecosystem (see serde or bevy)
|
|
||
| [package.metadata.docs.rs] | ||
| rustdoc-args = ["-Zunstable-options", "--generate-link-to-definition"] | ||
| features = ["wavefront"] |
There was a problem hiding this comment.
This allows to see the function in rustdoc.rs
| @@ -88,3 +89,7 @@ thiserror = { version = "1", optional = true } | |||
| oorandom = "11" | |||
| ptree = "0.4.0" | |||
| rand = { version = "0.8" } | |||
|
|
|||
| [package.metadata.docs.rs] | |||
| rustdoc-args = ["-Zunstable-options", "--generate-link-to-definition"] | |||
There was a problem hiding this comment.
this is already present in parry3d (we're in parry3d-f64 here)
| @@ -40,4 +40,4 @@ mod to_trimesh; | |||
| pub mod utils; | |||
|
|
|||
| #[cfg(feature = "wavefront")] | |||
| pub mod wavefront; | |||
| mod wavefront; | |||
There was a problem hiding this comment.
This module doesn´t have to be public, as it's implementing functions directly on TriMesh, which is public.
Making it public warns about undocumented module, as well as having nothing to show in it (the added function is within TriMesh)
