Propagate errors from mesh creation #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
commented
Sep 6, 2024
Vrixyz
commented
Sep 9, 2024
Vrixyz
force-pushed
the
717_trimesh_empty_error
branch
from
a51d7e9 to
c0498e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColliderBuilder::trimeshdoesn't return an error, and does not document potential panics rapier#717This will have impacts on user facing API.
Also, an interesting observation on current error handling withing intersection testing, where parry has been leaking a private type through function signatures, which results in "unknown types" (untypable variables, and no links to source definition in rustdoc. small repro: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=a414ede63130effa3b6e983d11a08bab