Example bounding sphere using macroquad #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebcrozet
approved these changes
Sep 20, 2024
| let cube2 = Cuboid::new(Vector3::new(0.5, 1.0, 0.5)); | ||
|
|
||
| let cube1_pos = na_from_mquad(lissajous_3d(elapsed_time)) * 4f32; | ||
| let cube1_pos = Isometry3::translation(cube1_pos.x, cube1_pos.y, cube1_pos.z); |
There was a problem hiding this comment.
Does this work?
Suggested change
| let cube1_pos = Isometry3::translation(cube1_pos.x, cube1_pos.y, cube1_pos.z); | |
| let cube1_pos = Isometry3::from(cube1_pos); |
There was a problem hiding this comment.
It would be great to have comments for every function from this module.
There was a problem hiding this comment.
I'll open a new PR for that
Vrixyz
force-pushed
the
example_bounding_sphere
branch
from
f3447e1 to
b68ed9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.09-04-2024.10.50.47.AM.webm
Screencast.from.09-04-2024.02.55.32.PM.webm