Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved stack! implementation, tests #1375

Merged
merged 38 commits into from
Jun 23, 2024
Merged

Improved stack! implementation, tests #1375

merged 38 commits into from
Jun 23, 2024

Commits on Jun 22, 2024

  1. Add macro for concatenating matrices

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    7ca1540 View commit details
    Browse the repository at this point in the history

  2. Replace DimUnify with DimEq::representative

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    1a3954d View commit details
    Browse the repository at this point in the history

  3. Add some simple cat macro output generation tests

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    b05aaf7 View commit details
    Browse the repository at this point in the history

  4. Fix formatting in cat macro code

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    1e7ef47 View commit details
    Browse the repository at this point in the history

  5. Add random prefix to cat macro output

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    78698d3 View commit details
    Browse the repository at this point in the history

  6. Add simple quote_spanned for cat macro

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    61fd5c7 View commit details
    Browse the repository at this point in the history

  7. Use generic_view_mut in cat macro

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    30c3ba6 View commit details
    Browse the repository at this point in the history

  8. Fix clippy lints in cat macro

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    db034cc View commit details
    Browse the repository at this point in the history

  9. Clean up documentation for cat macro

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    bb1b307 View commit details
    Browse the repository at this point in the history

  10. Remove identity literal from cat macro

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2fabc37 View commit details
    Browse the repository at this point in the history

  11. Allow references in input to cat macro

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2b51b98 View commit details
    Browse the repository at this point in the history

  12. Rename cat macro to stack

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    cb4544f View commit details
    Browse the repository at this point in the history

  13. Add more stack macro tests

    @birktj @sebcrozet
    birktj authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    47bd392 View commit details
    Browse the repository at this point in the history

  14. Add comment to explain reason for prefix in stack! macro

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    b6a88cf View commit details
    Browse the repository at this point in the history

  15. Refactor matrix!, stack! macros into separate modules

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    611cc84 View commit details
    Browse the repository at this point in the history

  16. Take all blocks by reference in stack! macro

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a9f23fe View commit details
    Browse the repository at this point in the history

  17. Make empty stack![] invocation well-defined

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    bbfa71b View commit details
    Browse the repository at this point in the history

  18. Fix stack! macro incorrect reference to data

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    bea2776 View commit details
    Browse the repository at this point in the history

  19. More extensive tests for stack! macro

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a5531d0 View commit details
    Browse the repository at this point in the history

  20. Move nalgebra-macros tests to nalgebra tests 

    By testing matrix!, stack! macros etc. in nalgebra, we ensure that
these macros are used in the same way that users will be using them.
    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    5c735aa View commit details
    Browse the repository at this point in the history

  21. Fix stack! code generation tests

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    88d60a5 View commit details
    Browse the repository at this point in the history

  22. Add back nalgebra as dev-dependency of nalgebra-macros

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    20bed13 View commit details
    Browse the repository at this point in the history

  23. Fix accidental wrong matrix! macro references in docs

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    30a183b View commit details
    Browse the repository at this point in the history

  24. Rewrite stack! documentation for clarity

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    10ff56c View commit details
    Browse the repository at this point in the history

  25. Formatting

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    47568a0 View commit details
    Browse the repository at this point in the history

  26. Skip formatting of macro, rustfmt messes it up

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    7ec2ffa View commit details
    Browse the repository at this point in the history

  27. Rewrite stack! impl for improved clarity, Span behavior 

    This improves error messages upon dimension mismatch, among other
things. I've also tried to make the implementation easier to understand,
adding some comments to help the reader understand the individual steps.
    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f2505e5 View commit details
    Browse the repository at this point in the history

  28. Use SameNumberOfRows/Columns instead of DimEq in stack! macro 

    This gives more accurate compiler errors if matrix dimensions
are mismatched.
    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f5ba6de View commit details
    Browse the repository at this point in the history

  29. Check that stack! panics at runtime for basic dimension mismatch

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    b2ea326 View commit details
    Browse the repository at this point in the history

  30. Add suggested edge cases from initial PR to tests

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    cff03ae View commit details
    Browse the repository at this point in the history

  31. stack! impl: use fixed prefix everywhere 

    This ensures that the expected generated code in tests
is the actual generated code when used in the wild.
    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4229d4a View commit details
    Browse the repository at this point in the history

  32. nalgebra-macros: Remove clippy pedantic, fix clippy complaints 

    pedantic seems to be mostly intent on wasting the programmer's time
    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    6f78813 View commit details
    Browse the repository at this point in the history

  33. Add stack! sanity tests for built-ins and Complex

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2d39770 View commit details
    Browse the repository at this point in the history

  34. Fix formatting in test

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    cf59bc9 View commit details
    Browse the repository at this point in the history

  35. Improve readability of format_ident! calls in stack! impl

    @Andlon @sebcrozet
    Andlon authored and sebcrozet committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    5b05ed5 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. fix trybuild tests

    @sebcrozet
    sebcrozet committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    b6650da View commit details
    Browse the repository at this point in the history

  2. chore: run tests with a specific rust version

    @sebcrozet
    sebcrozet committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    44f97dd View commit details
    Browse the repository at this point in the history

  3. More trybuild fixes

    @sebcrozet
    sebcrozet committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    5e3391e View commit details
    Browse the repository at this point in the history