Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic serialization example #560

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Basic serialization example #560

wants to merge 5 commits into from

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Jul 9, 2024 •
edited
Loading

fix for the serialization has been deployed in rapier, #568 adds in bevy_rapier.

@Vrixyz Vrixyz mentioned this pull request Jul 9, 2024
Merged
Vrixyz
Vrixyz commented Jul 9, 2024
View reviewed changes
src/plugin/context.rs Outdated Show resolved Hide resolved
@Vrixyz Vrixyz requested a review from sebcrozet July 26, 2024 14:36
sebcrozet
sebcrozet approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/plugin/context.rs Outdated Show resolved Hide resolved
@sebcrozet
Copy link
Member

One remark I didn’t mention for the review: teh serialization.rs example file should be named serialization2.rs.

@Vrixyz Vrixyz mentioned this pull request Aug 5, 2024
Merged
@Vrixyz Vrixyz force-pushed the RapierContext_serialization branch from 789a2bc to 5563ba9 Compare August 8, 2024 13:50
@Vrixyz Vrixyz force-pushed the RapierContext_serialization branch from 22a8e98 to ce41f2a Compare August 8, 2024 13:54
@Vrixyz Vrixyz mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebcrozet sebcrozet sebcrozet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vrixyz @sebcrozet