fix: find graphqlrc files relative to linted file #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eff8668 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Before this change, `loadConfigSync` from graphql-config would use `process.cwd` to find any .graphqlrc files.
With a project like this:
```
project/
- packages/
- app/
- schema.graphql
- .eslintrc
- .graphqlrc
- documents/
- operation.graphql
```
the VSCode Eslint plugin throws an error about not being able to find the schema.graphql file when linting the operation.graphql.
This change passes in the [`rootDir` option](https://graphql-config.com/load-config#rootdir) to `loadConfigSync` using the directory of the linted file. This will allow the .graphqlrc file to live in subfolders of the open project.
lennyburdette
force-pushed
the
graphql-config-load-relative
branch
from
ba9f2a5
to
eff8668
Compare
|
LGTM, thank you! |
dimaMachina
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change,
loadConfigSyncfrom graphql-config would useprocess.cwdto find any .graphqlrc files.With a project like this:
the VSCode Eslint plugin throws an error about not being able to find the schema.graphql file when linting the operation.graphql.
This change passes in the
rootDiroption toloadConfigSyncusing the directory of the linted file. This will allow the .graphqlrc file to live in subfolders of the open project.Fixes #899
Type of change
Screenshots/Sandbox (if appropriate/relevant):
https://stackblitz.com/edit/node-6fhvcm?file=README.md
How Has This Been Tested?
Unit tests, but I also installed my local copy in a separate project using
"file:"in package.json to verify that it works with the VSCode ESLint plugin.Test Environment:
@graphql-eslint/[email protected]:Checklist:
Thank you for your review!