Fix static folder destination on Windows and clean up its implementation #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, a file in static/file.txt was put into dist/static/file.txt instead of dist/file.txt. This was because we cut off everything before the first "/" in the target path string, but Windows separates folders with "\". Instead, we can use the somewhat hidden context feature from the CopyPlugin to get rid of the static/ prefix. See https://webpack.js.org/plugins/copy-webpack-plugin/#from-is-a-glob
|
Thank you so much for the fix @y0hy0h! I confirmed that it's still working as expected on Mac. Just released this with NPM version 1.4.1: https://github.com/dillonkearns/elm-pages/blob/master/CHANGELOG-NPM.md#141---2020-06-16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, a file in static/file.txt was put into dist/static/file.txt instead of dist/file.txt.
This was because we cut off everything before the first "/" in the target path string, but Windows separates folders with "".
Instead, we can use the somewhat hidden context feature from the CopyPlugin to get rid of the static/ prefix. See https://webpack.js.org/plugins/copy-webpack-plugin/#from-is-a-glob