Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go dependencies and remove replace statements #723

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

jauderho
Copy link
Contributor

@HappyHacker123 recently pointed out an issue with the pinned dependencies while filing an issue with dnscontrol (StackExchange/dnscontrol#3112)

Upon further inspection, it appears that the replace statements were put in place 4 years ago. This PR updates the dependencies, removes the replace statements and bumps the Go version to 1.22 which is the current oldest supported Go version.

Changes:

  • go: upgraded github.com/golang/protobuf v1.5.2 => v1.5.4
  • go: upgraded golang.org/x/net v0.23.0 => v0.29.0
  • go: upgraded golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5 => v0.23.0
  • go: upgraded golang.org/x/time v0.0.0-20220922220347-f3bd1da661af => v0.6.0
  • go: upgraded google.golang.org/appengine v1.6.7 => v1.6.8
  • go: upgraded google.golang.org/protobuf v1.33.0 => v1.34.2

@jauderho
Copy link
Contributor Author

Setting Go to 1.22 results in the following errors, so setting Go to 1.21 instead for now. go test -mod=vendor . now passes with no issue.

--- FAIL: TestRepository_ListTags (0.00s)
    registry_test.go:421: 
        	Error Trace:	/tmp/godo/registry_test.go:421
        	Error:      	Received unexpected error:
        	            	GET http://127.0.0.1:43432/v2/registry/test-registry/repositories/test%2Frepository/tags?page=1&per_page=1: 404 404 page not found
        	Test:       	TestRepository_ListTags
--- FAIL: TestRegistry_DeleteTag (0.00s)
    registry_test.go:449: 
        	Error Trace:	/tmp/godo/registry_test.go:449
        	Error:      	Received unexpected error:
        	            	DELETE http://127.0.0.1:40138/v2/registry/test-registry/repositories/test%2Frepository/tags/test-tag: 404 404 page not found
        	Test:       	TestRegistry_DeleteTag
--- FAIL: TestRegistry_ListManifests (0.00s)
    registry_test.go:519: 
        	Error Trace:	/tmp/godo/registry_test.go:519
        	Error:      	Received unexpected error:
        	            	GET http://127.0.0.1:35622/v2/registry/test-registry/repositories/test%2Frepository/digests?page=3&per_page=1: 404 404 page not found
        	Test:       	TestRegistry_ListManifests
--- FAIL: TestRegistry_DeleteManifest (0.00s)
    registry_test.go:549: 
        	Error Trace:	/tmp/godo/registry_test.go:549
        	Error:      	Received unexpected error:
        	            	DELETE http://127.0.0.1:40268/v2/registry/test-registry/repositories/test%2Frepository/digests/sha256:e692418e4cbaf90ca69d05a66403747baa33ee08806650b51fab815ad7fc331f: 404 404 page not found
        	Test:       	TestRegistry_DeleteManifest
FAIL
FAIL	github.com/digitalocean/godo	30.336s
FAIL

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks so much for the help cleaning this up!

@andrewsomething andrewsomething merged commit 2e0eaab into digitalocean:main Sep 10, 2024
8 checks passed
@HappyHacker123
Copy link

Thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants