Enable control plane firewall pointer arguments and trim spaces #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llDrLove
force-pushed
the
olove/enable-control-plane-firewall-pointer-arguments
branch
from
582d3f8 to
0966af0
Compare
llDrLove
commented
Jul 18, 2024
commands/functions.go
Outdated
| for _, parm := range parms { | ||
| if parm.Init { | ||
| keyVal := parm.Key + "=" + parm.Value | ||
| for _, param := range params { |
There was a problem hiding this comment.
Drive-by: Fixing some Spell check CI failures https://github.com/digitalocean/doctl/actions/runs/9994130657/job/27623184485?pr=1555
timoreimann
reviewed
Jul 18, 2024
commands/kubernetes.go
Outdated
| @@ -1679,6 +1675,9 @@ func buildClusterCreateRequestFromArgs(c *CmdConfig, r *godo.KubernetesClusterCr | |||
| if r.ControlPlaneFirewall == nil { | |||
| r.ControlPlaneFirewall = &godo.KubernetesControlPlaneFirewall{} | |||
| } | |||
| for i := range controlPlaneFirewallAllowedAddresses { | |||
| controlPlaneFirewallAllowedAddresses[i] = strings.ReplaceAll(controlPlaneFirewallAllowedAddresses[i], " ", "") | |||
There was a problem hiding this comment.
I'm inclined to prefer strings.TrimSpace() which also handles all sorts of unicode variants.
Similar for the other usage elsewhere.
There was a problem hiding this comment.
Sure, I've refactored it to use strings.TrimSpace()
timoreimann
reviewed
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable-control-plane-firewallflag is a optional boolean and only pass the configuration when needed.