Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not update the go version since we are up to date on
1.21
. Ran:Due to changes in upstream (they removed 1. webhook Host, Port, CertDir fields 2. MetricsBindAddress option), I had to modify the
ctrl.Options
fieldsdo-operator/api/v1alpha1/webhook_suite_test.go
Lines 145 to 158 in 8867b89
do-operator/main.go
Lines 87 to 94 in 8867b89
and added methods to
fakeDatabasesService
to satisfy the interface requirements here