Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update do operator [CON-9885] #52

Merged
merged 1 commit into from
Jan 11, 2024
Merged

update do operator [CON-9885] #52

merged 1 commit into from
Jan 11, 2024

Conversation

dhij
Copy link
Contributor

@dhij dhij commented Jan 11, 2024

Did not update the go version since we are up to date on 1.21. Ran:

go get -u ./...
go mod tidy
go mod vendor

Due to changes in upstream (they removed 1. webhook Host, Port, CertDir fields 2. MetricsBindAddress option), I had to modify the ctrl.Options fields

mgr, err := ctrl.NewManager(cfg, ctrl.Options{
Scheme: scheme,
WebhookServer: &webhook.DefaultServer{
Options: webhook.Options{
Host: webhookInstallOptions.LocalServingHost,
Port: webhookInstallOptions.LocalServingPort,
CertDir: webhookInstallOptions.LocalServingCertDir,
},
},
Metrics: server.Options{
BindAddress: "0",
},
LeaderElection: false,
})
and

do-operator/main.go

Lines 87 to 94 in 8867b89

WebhookServer: &webhook.DefaultServer{
Options: webhook.Options{
Port: 9443,
},
},
Metrics: server.Options{
BindAddress: metricsAddr,
},

and added methods to fakeDatabasesService to satisfy the interface requirements here

@dhij dhij requested review from llDrLove and kperath January 11, 2024 19:14
Copy link
Contributor

@llDrLove llDrLove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐥

@dhij dhij merged commit 9e1b9dc into main Jan 11, 2024
1 check passed
@dhij dhij deleted the ihwang/update-operator branch January 11, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants