Add search_widget and introduction #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxammann
approved these changes
Oct 9, 2022
| @@ -0,0 +1,117 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
Comment on lines
+21
to
+22
| <textarea id="integreat_textarea_html" class="integreat_class_input"> | ||
| <div id="integreat-search-widget"> |
There was a problem hiding this comment.
Formatting is slightly off here. I usually use prettier in HTML/JS projects: https://prettier.io/
| <textarea id="integreat_textarea_html" class="integreat_class_input"> | ||
| <div id="integreat-search-widget"> | ||
| <img src="./assets/integreat-app-logo.png"> | ||
| <p>Mehrsprachige Informationen in <!-- Region --> finden!</p> |
There was a problem hiding this comment.
Should there be a placeholder inserted at <!-- Region -->?
| <p>Mehrsprachige Informationen in <!-- Region --> finden!</p> | ||
| <form method="get"> | ||
| <input class="integreat_search" id="integreat_search" name="query" placeholder="z.B. Sprachkurse"> | ||
| <input class="integreat_submit" id="integreat_submit" type="submit" value="SUCHEN"> |
There was a problem hiding this comment.
You can also use text-transform to make something uppercase: https://developer.mozilla.org/en-US/docs/Web/CSS/text-transform
| CSS einbetten | ||
| </h3> | ||
| <textarea id="integreat_textarea_css" class="integreat_class_input"> | ||
| <style> |
There was a problem hiding this comment.
I think those styles can be moved to the .css file.
| </div> | ||
| <div><h3>Javascript einbetten</h3> | ||
| <textarea id="integreat_textarea_js" class="integreat_class_input"> | ||
| <script> |
There was a problem hiding this comment.
This can be moved to the .js file.
| function add_to_clipboard(id) { | ||
| let input_search_widget = document.getElementById(id) | ||
| input_search_widget.select(); | ||
| document.execCommand("Copy"); |
There was a problem hiding this comment.
I never used any copy API of the browser. But this API seems to be removed: https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the search widget as a javascript file, based on the Integreat Search Widget Wordpress Plugin.