Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error at bulk link ignore/unignore #3186

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

MizukiTemma
Copy link
Member

@MizukiTemma MizukiTemma commented Nov 7, 2024

Short description

This PR fixes the bug which occurs when URLs are ignored or unignored by bulk action.

Proposed changes

  • Add prefetch_region_links=True

Alternatively we could probably set prefetch_region_links as default True

Side effects

Resolved issues

Fixes: #3183


Pull Request Review Guidelines

Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick fix!

I think I accidentally introduced this in #3120, because I thought the region links would not be required for this query.

@MizukiTemma
Copy link
Member Author

Thanks a lot for the quick fix!

I think I accidentally introduced this in #3120, because I thought the region links would not be required for this query.

And neither I noticed it while reviewing 🙈

Copy link
Contributor

@lunars97 lunars97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now as expected! 🚀 Thank you :)

@MizukiTemma MizukiTemma merged commit 1e3e18c into develop Nov 8, 2024
5 checks passed
@MizukiTemma MizukiTemma deleted the bug/ignore_bulk_action branch November 8, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 error when executing bulk action "ignore" in link checker
3 participants