Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGAPP-665: Disable flipper builds in CI #315

Merged
merged 10 commits into from
Jun 22, 2021
Merged

Conversation

maxammann
Copy link
Member

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

@maxammann maxammann marked this pull request as draft June 5, 2021 14:45
@maxammann maxammann force-pushed the IGAPP-665-ci-disable-flipper branch from 301bed7 to 190fd5a Compare June 9, 2021 11:51
@sarahsporck
Copy link
Contributor

Saved around 10 mins, as expected. Might be worth it 🤷🏼‍♀️. But only if there actually is an easy workaround.

@maxammann
Copy link
Member Author

Yep, worth it, not sure yet how to handle the lock file.

  • One solution would be to have two lockfiles.
  • The other is to remove the --deployment as I did for testing

@maxammann maxammann force-pushed the IGAPP-665-ci-disable-flipper branch from 760bde2 to e14d265 Compare June 13, 2021 20:11
@steffenkleinle
Copy link
Member

The option with two lockfiles would provide additional security as it is always clear which dependencies are used, right? Could lead to diverging dependencies though...

@maxammann
Copy link
Member Author

The option with two lockfiles would provide additional security as it is always clear which dependencies are used, right? Could lead to diverging dependencies though...

Actually this is not possible with cocoapods, so this is only a theoretical option :D

@sarahsporck
Copy link
Contributor

Actually why would you want to enable flipper on main? As far as I know flipper is/should also not be linked in release mode. Probably I am missing something, right?

@steffenkleinle
Copy link
Member

It is more about enforcing the correct dependencies/lockfile and flipper on main is just a drawback.

@maxammann maxammann force-pushed the IGAPP-665-ci-disable-flipper branch from 2a55a42 to 9dbb5b5 Compare June 19, 2021 09:13
@maxammann
Copy link
Member Author

I decided to just remove the --deployment flag, because:

  • Conditionally using the flag or not adds a lot of complexity to CI scripts
  • The benefit is not clear. 99% of people do not use these flags
  • If you forget to update the lock file then somebody will eventually find it or the build will fail in other ways.

@maxammann maxammann marked this pull request as ready for review June 19, 2021 09:19
@maxammann maxammann enabled auto-merge June 20, 2021 14:35
@maxammann maxammann merged commit fdca7e1 into main Jun 22, 2021
@maxammann maxammann deleted the IGAPP-665-ci-disable-flipper branch June 22, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants