-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGAPP-665: Disable flipper builds in CI #315
Conversation
301bed7
to
190fd5a
Compare
Saved around 10 mins, as expected. Might be worth it 🤷🏼♀️. But only if there actually is an easy workaround. |
Yep, worth it, not sure yet how to handle the lock file.
|
760bde2
to
e14d265
Compare
The option with two lockfiles would provide additional security as it is always clear which dependencies are used, right? Could lead to diverging dependencies though... |
Actually this is not possible with cocoapods, so this is only a theoretical option :D |
Actually why would you want to enable flipper on main? As far as I know flipper is/should also not be linked in release mode. Probably I am missing something, right? |
It is more about enforcing the correct dependencies/lockfile and flipper on main is just a drawback. |
2a55a42
to
9dbb5b5
Compare
I decided to just remove the
|
This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.