-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1672: Improve birthday field #1767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on firefox, works great 🎉
bbdf70f
to
ca0080a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -12,6 +12,7 @@ const StyledButton = styled.button<{ $viewportSmall: boolean }>` | |||
flex-direction: column; | |||
margin-right: 4px; | |||
cursor: pointer; | |||
color: #5f6b7c; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to move this color to a constant in the colors file for reuse? I understand that a separate cleanup task is planned for moving existing colors, but keeping new feature colors organized in the central file now could save us time in the future. That way, we won’t need to revisit this feature when we tackle that cleanup, and it will keep everything tidy as we go. Thank you!
I think this issue will be solved with #1779 and is as you said really minor. |
40e5be8
to
b4c271a
Compare
…-field # Conflicts: # administration/src/bp-modules/self-service/CardSelfServiceForm.tsx # administration/src/bp-modules/self-service/CardSelfServiceView.tsx # administration/src/bp-modules/self-service/components/FormErrorMessage.tsx # administration/src/cards/Card.test.ts # administration/src/cards/Card.ts
Short description
As a koblenz pass applicant i want to provide my birthday easily on a mobile device
Proposed changes
Note
Side effects
Testing
Resolved issues
Fixes: #1672