Updated archiving script #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeffatChowdhury
suggested changes
Nov 29, 2022
| print("No datasets to archive................................................") | ||
| else: | ||
| df = pd.DataFrame(dataset_ids) | ||
| s3.Bucket("s3://deafrica-landsat/status-report/archived/").upload_file( |
There was a problem hiding this comment.
We need to use a folder on S3 dedicated to these archive logs instead of the Landsat folder @Indiphile
SeffatChowdhury
suggested changes
Nov 30, 2022
| # Upload to AWS s3 bucket | ||
| s3.Bucket("archive-deafrica-datasets").upload_file( | ||
| Filename=PRODUCT_NAME + "_archived.csv", | ||
| Key="crop-mask/" + PRODUCT_NAME + "_archived.csv", |
There was a problem hiding this comment.
How can we avoid the specific reference to "crop-mask"?
There was a problem hiding this comment.
To avoid referencing to the folder "crop-mask", key must include the file name only. For example in this case : if
Key=PRODUCT_NAME + "_archived.csv" , the file will uploaded to the root folder of the S3 bucket. The reason why I created the crop-mask folder is to store related product in one folder.
SeffatChowdhury
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.