Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_ard changes #512

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

load_ard changes #512

wants to merge 2 commits into from

Conversation

mickwelli
Copy link
Contributor

Proposed changes

Changes to load_ard() to accommodate Sentinel-2 C1. Only works in dev while C1 is available there.

Checklist (replace [ ] with [x] to check off)

  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended)
  • Include relevant tags in the first notebook cell and re-use tags if possible
  • Ensure appropriate colour schemes have been used to maximise accessibility for vision impairment. Test your images or learn more with Coblis or TPGI
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

@mickwelli mickwelli requested a review from vikineema June 11, 2024 05:29
@mickwelli mickwelli requested a review from fangfy June 27, 2024 03:02
@mickwelli
Copy link
Contributor Author

Hi @vikineema, when we merge this PR once s2_l2a_c1 data is in prod, would we need to update the tools version?

@vikineema
Copy link
Collaborator

Hi @vikineema, when we merge this PR once s2_l2a_c1 data is in prod, would we need to update the tools version?

Hi @mickwelli , yes we would need to publish an updated tools version , I think 2.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants