-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coastal change country #459
base: main
Are you sure you want to change the base?
Conversation
Coastal change statistics for countries
…untry' into coastal-change-country
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool notebooks, I think the bar charts and text statements are especially interesting.
I've committed and pushed a few markdown edits I made as I went along. Additionally, under executed cell 7 I suggest the following change:
“We can inspect the distributions of the good measurements and the significant changes. Significant changes have a significance (p-value) of less than 0.01, which indicates a shoreline is measured to have undergone consistent change through time.”
Suggest revision to:
“We can inspect the distributions of the good measurements and the significant changes. Changes with a p-value of less than 0.01 indicate that a shoreline has undergone change greater than would be expected with natural variation.”
In the sea level rise notebook I cannot find the slr_data
folder, wondering if this is missing or whether this needs to be downloaded by the user?
Proposed changes
Include a brief description of the changes being proposed, and why they are necessary.
Checklist (replace
[ ]
with[x]
to check off)Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended)