Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coastal change country #459

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Coastal change country #459

wants to merge 24 commits into from

Conversation

fangfy
Copy link
Contributor

@fangfy fangfy commented Jun 21, 2023

Proposed changes

Include a brief description of the changes being proposed, and why they are necessary.

Checklist (replace [ ] with [x] to check off)

  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended)
  • Include relevant tags in the first notebook cell and re-use tags if possible
  • Ensure appropriate colour schemes have been used to maximise accessibility for vision impairment. Test your images or learn more with Coblis or TPGI
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Copy link
Contributor

@mickwelli mickwelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool notebooks, I think the bar charts and text statements are especially interesting.

I've committed and pushed a few markdown edits I made as I went along. Additionally, under executed cell 7 I suggest the following change:

“We can inspect the distributions of the good measurements and the significant changes. Significant changes have a significance (p-value) of less than 0.01, which indicates a shoreline is measured to have undergone consistent change through time.”
Suggest revision to:
“We can inspect the distributions of the good measurements and the significant changes. Changes with a p-value of less than 0.01 indicate that a shoreline has undergone change greater than would be expected with natural variation.”

In the sea level rise notebook I cannot find the slr_data folder, wondering if this is missing or whether this needs to be downloaded by the user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants