Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using WOfS Classifier on sentinel 2 #438

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

nanaboamah89
Copy link
Contributor

Using the WOfS classifier on the Sentinel 2 and comparing it to MNDWI.

Checklist (replace [ ] with [x] to check off)

  • [ x] Remove any unused Python packages from Load packages
  • [x ] Remove any unused/empty code cells
  • [ x] Remove any guidance cells (e.g. General advice)
  • [x ] Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended)
  • [x ] Include relevant tags in the first notebook cell and re-use tags if possible
  • [ x] Ensure appropriate colour schemes have been used to maximise accessibility for vision impairment. Test your images or learn more with Coblis or TPGI
  • [ x] Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Closes issues (optional)

  • Closes Issue #000

@nanaboamah89 nanaboamah89 marked this pull request as ready for review April 12, 2023 13:11
Copy link
Contributor

@fangfy fangfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The title and descriptons for the notebook are incomplete?
  • S2 cloud mask appears to have a lot of issue for this area, including masking out water on 2017-12-15. Suggest find a different location or investigate the mask flags used.
  • Does wofs_classify(ds) give nan over masked out regions? In cell 10, when you plot (ds_wofs.wofs == 1), you can't tell between dry and no data. Similarly for the MNDWI plot.

@nanaboamah89 nanaboamah89 requested review from fangfy April 17, 2023 11:30
@nanaboamah89 nanaboamah89 marked this pull request as draft November 15, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants