Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added loading spinner #17

Merged
merged 2 commits into from
Mar 5, 2024
Merged

added loading spinner #17

merged 2 commits into from
Mar 5, 2024

Conversation

yongkfn
Copy link
Contributor

@yongkfn yongkfn commented Mar 1, 2024

Added a spinner component whenever waiting for a query response, so that users know something is still happening

@yongkfn
added loading spinner
ef69e3b 
Added a spinner component whenever waiting for a query response, so that users know something is still happening
@yongkfn yongkfn requested a review from xKhronoz March 1, 2024 13:16
xKhronoz
xKhronoz approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@xKhronoz xKhronoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Updated loading spinner to use native tailwinds and SVG icon.
  • Moved loading spinner into 'send' button, with connections to loading state.

@xKhronoz xKhronoz merged commit 719d697 into main Mar 5, 2024
3 checks passed
@yongkfn
Copy link
Contributor Author

yongkfn commented Mar 6, 2024

Thanks Yee Kit, this looks much better

@xKhronoz xKhronoz deleted the Adding-loader-to-chat-generation branch March 7, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xKhronoz xKhronoz xKhronoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yongkfn @xKhronoz