Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit (extract from jsonld-signatures). #1

Merged
merged 18 commits into from
Mar 19, 2021
Merged

Conversation

dmitrizagidulin
Copy link
Contributor

@dmitrizagidulin dmitrizagidulin commented Aug 9, 2020

lib/create-jws.js Outdated Show resolved Hide resolved
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving conditionally, see comments. Thanks!

lib/JwsLinkedDataSignature.js Outdated Show resolved Hide resolved
}

async matchProof({proof, document, purpose, documentLoader, expansionMap}) {
if(!await super.matchProof(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Extending suites will need to check for their contexts here and in sign. We probably want a note about that somewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a note - does that work?

package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@davidlehn
Copy link
Member

CHANGELOG needs updating for name and/or other entries.

package.json Outdated Show resolved Hide resolved
@dmitrizagidulin dmitrizagidulin merged commit feac70a into master Mar 19, 2021
@dlongley dlongley deleted the initial branch October 25, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants