Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addDocuments API and overwrite option. #15

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

davidlehn
Copy link
Member

No description provided.

@davidlehn davidlehn requested a review from dlongley July 31, 2024 03:28
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5917532) to head (d8b83b5).

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #15      +/-   ##
===========================================
+ Coverage   98.40%   100.00%   +1.59%     
===========================================
  Files           2         2              
  Lines         125       143      +18     
===========================================
+ Hits          123       143      +20     
+ Misses          2         0       -2     
Files Coverage Δ
lib/JsonLdDocumentLoader.js 100.00% <100.00%> (+1.66%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5917532...d8b83b5. Read the comment docs.

Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one suggestion for the new API.

lib/JsonLdDocumentLoader.js Outdated Show resolved Hide resolved
@davidlehn
Copy link
Member Author

Backed out the overwrite option for now to avoid breaking change.

@davidlehn davidlehn merged commit 25daaf9 into main Jul 31, 2024
5 checks passed
@davidlehn davidlehn deleted the add-adddocuments branch July 31, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants