Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps, fix version option. #26

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Update deps, fix version option. #26

merged 4 commits into from
Jan 4, 2024

Conversation

davidlehn
Copy link
Member

No description provided.

- Node.js 14 no longer supported with updated dev deps.
Copy link
Contributor

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better than my hacky fix. Thanks, @davidlehn!

Only load the package in the rare case of showing the version. This is
somewhat dependent on the current behavior of commander and how it uses
the version parameter.
@davidlehn
Copy link
Member Author

I couldn't help myself. It now uses magic to only load the package.json version field when needed. What could go wrong? This could also do dynamic imports for the node bits needed for this, but not today.

@davidlehn davidlehn merged commit c5a9741 into main Jan 4, 2024
1 check passed
@davidlehn davidlehn deleted the updates branch January 4, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants