Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static version number to fix #13. #23

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Add static version number to fix #13. #23

merged 2 commits into from
Sep 25, 2023

Conversation

BigBlueHat
Copy link
Contributor

No description provided.

@BigBlueHat
Copy link
Contributor Author

This could be done more dynamically...but not sure it's worth the effort atm. Let me know if you disagree @davidlehn

dlongley
dlongley approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now -- but will get frustrating quickly once new versions need to be released and we forget about it :). Note that the last released version was 1.0.0, which is what should be reflected (see suggestion).

bin/jsonld.js Outdated Show resolved Hide resolved
@BigBlueHat BigBlueHat merged commit 755e6bd into main Sep 25, 2023
1 check passed
@davidlehn davidlehn deleted the add-version-output branch January 2, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@davidlehn davidlehn Awaiting requested review from davidlehn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BigBlueHat @dlongley