-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mocha 10 #24
Use mocha 10 #24
Conversation
Thanks for picking this up @aljones15 |
CHANGELOG.md
Outdated
### Added | ||
- **BREAKING**: added `engines.node >= 12` to `package.json` | ||
### Changed | ||
- **BREAKING**: Upgraded to mocha 10. [See mocha 10's changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there's a special reason, we can probably leave finding changelogs as an exercise for the reader.
- **BREAKING**: Upgraded to mocha 10. [See mocha 10's changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) | |
- **BREAKING**: Update to `mocha@10`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not as sure on this one, the major reason for the breaking release is the upgrade to mocha 10 so I think we should link to their change log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it's just a hassle to do in general. Maybe link direct to v10 section: https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#1000--2022-05-01
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Co-authored-by: David I. Lehn <[email protected]>
Co-authored-by: David I. Lehn <[email protected]>
71f150b
to
681bf10
Compare
@davidlehn @aljones15 @dlongley I just tested this with mocha@10 on a few bedrock libs As for the Node >= 14 requirement constituting a breaking change. Bedrock core started requiring node 14+ over a year ago in v5: https://github.com/digitalbazaar/bedrock/blob/main/CHANGELOG.md#500---2022-03-31 This lib (bedrock-test) has a peer dep requirement of I propose that this mocha update be released as a minor release to avoid having to touch the nearly 60 libs that use it. Any objections? |
Minor release is ok with me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with a minor release based on @mattcollier's comments.
Addresses: #23
To Do
Mocha
class