Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added draggability to playhead #175

Merged
merged 4 commits into from
Oct 23, 2018
Merged

added draggability to playhead #175

merged 4 commits into from
Oct 23, 2018

Conversation

4d4mm
Copy link
Contributor

@4d4mm 4d4mm commented Oct 22, 2018

No description provided.

@4d4mm 4d4mm requested a review from stephenwf October 22, 2018 13:17
stephenwf
stephenwf requested changes Oct 22, 2018
View reviewed changes
Copy link
Member

@stephenwf stephenwf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the IE issue, and good to go

@4d4mm
Copy link
Contributor Author

4d4mm commented Oct 23, 2018

Updated. Decided to not handle events on the playhead element, the event's are handled on the scrubber instead as it was originally.

@4d4mm 4d4mm merged commit d2f401f into master Oct 23, 2018
@stephenwf stephenwf deleted the feature/draggable-playhead branch January 3, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenwf stephenwf stephenwf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4d4mm @stephenwf