Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a chunky PR, but a relatively small change. It is non-breaking.
Why?
At the moment, to change a the styling on a label requires building a separate project, building, a pull request, and finally a published package, and then finally a PR to Madoc with a version bump - no easy visibility of the change - and then a Madoc build, review, merge, publish. Madoc is the only consumer of the capture model packages, and development of the two are closely tied.
We need to accelerate the development of capture models, and the UI is becoming more interconnected with Madoc (while still being reusable). This change will make iterations quicker, and changes clearer.
How?
@capture-model/*
dependenciesThe old repository
The last 2 packages still in the old repository are the following
@capture-models/repository
@capture-models/server
These will be merged together into a new repository, and a single package will be created for spinning up a server easily with NodeJS (as it currently works now). The new source of truth for the types and helpers is Madoc.
The NPM folder in Madoc is there to allow Madoc to publish multiple packages, each tied to Madoc published tags. A new package will be created under the
@capture-models/
name space (e.g.@capture-models/core
) that will contain all of the current helpers, plugin systems and types provided by the previous packages. It makes more sense for these to be tied to Madoc versions for now, as that is the primary (and currently only) consumer of those packages.Until that is in place however, the code for saving capture models will need to be updated with changes to types or helpers (which is rare - for helpers used by both). Any helpers used exclusively by the server will be copied across to there, and remove from here.
Benefits
Downsides
Follow up work